Re: [PATCH v3 01/12] ARM: EXYNOS: Make exynos machine_ops as static

[Pankaj Dubey]

Hi Sachin,

On 04/30/2014 03:00 PM, Sachin Kamat wrote:
> Hi Pankaj,
>
> On 30 April 2014 10:47, Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx> wrote:
> > As machine function ops are used only in this file let's make
> > them static.
> >
> > Signed-off-by: Pankaj Dubey <pankaj.dubey@xxxxxxxxxxx>
> > ---
> >   arch/arm/mach-exynos/exynos.c |    6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
> > index 3d69e8d..06dcce5 100644
> > --- a/arch/arm/mach-exynos/exynos.c
> > +++ b/arch/arm/mach-exynos/exynos.c
> > @@ -198,7 +198,7 @@ static struct map_desc exynos5_iodesc[] __initdata = {
> >          },
> >   };
> >
> > -void exynos_restart(enum reboot_mode mode, const char *cmd)
> > +static void exynos_restart(enum reboot_mode mode, const char *cmd)
> >   {
> >          struct device_node *np;
> >          u32 val = 0x1;
> > @@ -239,7 +239,7 @@ void __init exynos_cpufreq_init(void)
> >          platform_device_register_simple("exynos-cpufreq", -1, NULL, 0);
> >   }
> >
> > -void __init exynos_init_late(void)
> > +static void __init exynos_init_late(void)
> >   {
> >          if (of_machine_is_compatible("samsung,exynos5440"))
> >                  /* to be supported later */
> > @@ -300,7 +300,7 @@ static void __init exynos_map_io(void)
> >                  iotable_init(exynos5250_iodesc, ARRAY_SIZE(exynos5250_iodesc));
> >   }
> >
> > -void __init exynos_init_io(void)
> > +static void __init exynos_init_io(void)
> >   {
> >          debug_ll_io_init();
>
> The declarations from common.h should also be removed in this patch to
> avoid the below
> build errors:

Thanks. I will merge changes in common.h in this patch itself.

> arch/arm/mach-exynos/exynos.c:198:13: error: static declaration of
> âexynos_restartâ follows non-static declaration
>   static void exynos_restart(enum reboot_mode mode, const char *cmd)
>               ^
> In file included from arch/arm/mach-exynos/exynos.c:31:0:
> arch/arm/mach-exynos/common.h:22:6: note: previous declaration of
> âexynos_restartâ was here
>   void exynos_restart(enum reboot_mode mode, const char *cmd);
>        ^
> arch/arm/mach-exynos/exynos.c:235:20: error: static declaration of
> âexynos_init_lateâ follows non-static declaration
>   static void __init exynos_init_late(void)
>                      ^
> In file included from arch/arm/mach-exynos/exynos.c:31:0:
> arch/arm/mach-exynos/common.h:25:6: note: previous declaration of
> âexynos_init_lateâ was here
>   void exynos_init_late(void);
>        ^
> arch/arm/mach-exynos/exynos.c:296:20: error: static declaration of
> âexynos_init_ioâ follows non-static declaration
>   static void __init exynos_init_io(void)
>                      ^
> In file included from arch/arm/mach-exynos/exynos.c:31:0:
> arch/arm/mach-exynos/common.h:21:6: note: previous declaration of
> âexynos_init_ioâ was here
>   void exynos_init_io(void);


--
Best Regards,
Pankaj Dubey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/