Re: [PATCH 1/1] Revert "affs: use ->kill_sb() to simplify ->put_super() and failure exits of ->mount()"

From: Fabian Frederick
Date: Wed Apr 30 2014 - 01:10:59 EST


On Tue, 29 Apr 2014 15:30:22 -0700
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Tue, 29 Apr 2014 21:35:12 +0200 Fabian Frederick <fabf@xxxxxxxxx> wrote:
>
> > This reverts commit 842a859db26b70 due to permanent crash issues.
> >
> > Sample scenario:
> >
> > dd if=/dev/zero of=f1 bs=1M count=1
> > losetup -f f1
> > mount -t affs -o unknownoption /dev/loop0 mnt1
> > -> crash
>
> Thanks for the bug report ;)
Sorry, it was only tested under X window and box was completely frozen.
I guess Al can test with the simple steps above or I can make a complete console report.

>
> > With patch revert:
> > "mount: wrong fs type, bad option, bad superblock on /dev/loop0"
>
> But reverting is premature. With this info Al will presumably fix this up.
Of course :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/