Re: [PATCH 11/47] staging/lustre/ptlrpc: add rpc_cache

[Oleg Drokin]

Hello!

On Apr 29, 2014, at 5:46 AM, Dan Carpenter wrote:
>> 
>> +		/* Fall through */
>> 	case 7:
>> 		sptlrpc_fini();
>> -	case 5:
>> +		/* Fall through */
>> +	case 6:
>> 		ldlm_exit();
>> -	case 4:
>> +		/* Fall through */
>> +	case 5:
>> 		ptlrpc_stop_pinger();
>> -	case 3:
>> +		/* Fall through */
>> +	case 4:
>> 		ptlrpc_connection_fini();
>> -	case 2:
>> +		/* Fall through */
>> +	case 3:
>> 		ptlrpc_exit_portals();
>> +		/* Fall through */
>> +	case 2:
>> +		ptlrpc_request_cache_fini();
>> +		/* Fall through */
>> 	case 1:
>> 		ptlrpc_hr_fini();
>> 		req_layout_fini();
>> +		/* Fall through */
>> 	default: ;
>> 	}
>> 
> 
> Heh.  Oh wow.  That's horrible.  :P
> 
> Hopefully next time someone will fix this pile of monkey poo instead
> just renumbering all the grains of corn.

Agreed.
We actually have it fixed, but it again came with some other rework that
we are probably not ready to merge anywhere yet.
I guess I can extract just this cleanup ahead of time.

Bye,
    Oleg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/