Re: [PATCH] staging: rts5208: fix static checker warnings

From: micky
Date: Tue Apr 29 2014 - 21:16:12 EST


Hi Dan,

I have send this patch to fix the static checker warning, but not applied yet.

Best Regards.
micky.
On 04/02/2014 05:58 PM, micky_ching@xxxxxxxxxxxxxx wrote:
From: Micky Ching <micky_ching@xxxxxxxxxxxxxx>

The patch fa590c222fba: "staging: rts5208: add support for rts5208
and rts5288" from Nov 12, 2013, leads to the following static checker
warning:
drivers/staging/rts5208/rtsx_chip.c:107 rtsx_enable_bus_int()
warn: add curly braces?
This warning is produced because incorrect code indent.

Signed-off-by: Micky Ching <micky_ching@xxxxxxxxxxxxxx>
---
drivers/staging/rts5208/rtsx_chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rts5208/rtsx_chip.c b/drivers/staging/rts5208/rtsx_chip.c
index 6426807..7907e93 100644
--- a/drivers/staging/rts5208/rtsx_chip.c
+++ b/drivers/staging/rts5208/rtsx_chip.c
@@ -104,7 +104,7 @@ void rtsx_enable_bus_int(struct rtsx_chip *chip)
if (chip->ic_version >= IC_VER_C)
reg |= DELINK_INT_EN;
#ifdef SUPPORT_OCP
- reg |= OC_INT_EN;
+ reg |= OC_INT_EN;
#endif
if (!chip->adma_mode)
reg |= DATA_DONE_INT_EN;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/