Re: ioctl CAP_LINUX_IMMUTABLE is checked in the wrong namespace

From: Andy Lutomirski
Date: Tue Apr 29 2014 - 20:34:15 EST


On Tue, Apr 29, 2014 at 5:32 PM, Theodore Ts'o <tytso@xxxxxxx> wrote:
> On Wed, Apr 30, 2014 at 12:16:41AM +0000, Serge Hallyn wrote:
>> I forget the details, but there was another case where I wanted to
>> have the userns which 'owns' the whole fs available. I guess we'd
>> have to check against that instead of using inode_capable.
>
> Yes, that sounds right.
>
> And *please* tell me that that under no circumstances can anyone other
> than root@init_user_ns is allowed to use mknod....

I haven't read the code, but I tried it the other day, and I got
-EPERM. So we're okay for now. (Well, other than the issue I just
sent to security@xxxxxxxxxx, but that's not quite the same thing.)

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/