Re: [PATCH v2 4/5] ACPI/PCI: Warn if we have to "guess" host bridge node information

[Borislav Petkov]

On Mon, Apr 28, 2014 at 03:24:39PM -0600, Myron Stowe wrote:
> >> @@ -489,8 +489,12 @@ struct pci_bus *pci_acpi_scan_root(struct acpi_pci_root *root)
> >>       }
> >>
> >>       node = acpi_get_node(device->handle);
> >> -     if (node == NUMA_NO_NODE)
> >> +     if (node == NUMA_NO_NODE) {
> >>               node = x86_pci_root_bus_node(busnum);
> >> +             if (node != NUMA_NO_NODE)
> >> +                     dev_info(&device->dev, FW_BUG "No _PXM; guessing node number %x\n",
> >
> > Hmm, I'm not really convinced this message is user-friendly enough. Can
> > we be more descriptive here please?
> >
> 
> How about -
>   dev_info(&device->dev, FW_BUG "no _PXM; falling back to node %d from
> hardware (may be inconsistent with ACPI node numbers)\n", node);

Yep, better.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/