Re: [PATCH] mmc: rtsx: usb backend needs LED support

From: Arnd Bergmann
Date: Tue Apr 29 2014 - 08:47:00 EST


On Tuesday 29 April 2014 13:05:15 Ulf Hansson wrote:
> On 29 April 2014 11:45, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> > drivers/built-in.o: In function `rtsx_usb_sdmmc_drv_remove':
> > :(.text+0x806480): undefined reference to `led_classdev_unregister'
> > drivers/built-in.o: In function `rtsx_usb_sdmmc_drv_probe':
> > :(.text+0x806708): undefined reference to `led_classdev_register'
> >
> > This adds an explicit dependency in Kconfig
>
> I think the proper solution is to fix the dependency in the driver code instead.
>
> There are already some ifdefs hackery for making it optional to use
> leds, apparently that's not working properly.
>

Ah, right, I misinterpreted the bug. Here is a new version:

8<---------