Re: [PATCH 34/47] staging/lustre/libcfs: add CPU table functions for uniprocessor

[Dan Carpenter]

On Sun, Apr 27, 2014 at 01:06:58PM -0400, Oleg Drokin wrote:
>  int
> +cfs_cpt_table_print(struct cfs_cpt_table *cptab, char *buf, int len)
> +{
> +	int	rc = 0;

GCC has a feature where it warns about unitialized variables.  If you do
bogus it disables this safety feature.  Also the bogus assignment is
confusing for people trying to read the code.

> +
> +	rc = snprintf(buf, len, "%d\t: %d\n", 0, 0);
> +	len -= rc;
> +	if (len <= 0)
> +		return -EFBIG;

It would be more clear to say:

	rc = snprintf(buf, len, "%d\t: %d\n", 0, 0);
	if (rc >= len)
		return -EFBIG;

	return rc;

regards,
dan carpenter

> +
> +	return rc;
> +}
> +EXPORT_SYMBOL(cfs_cpt_table_print);
> +

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/