Re: lockdep warning after recent cleanup in console code

[Jan Kara]

On Mon 28-04-14 15:36:42, Steven Rostedt wrote:
> On Mon, 28 Apr 2014 21:24:16 +0200
> Jan Kara <jack@xxxxxxx> wrote:
> 
> 
> >   So I had a look and we are missing mutex_release() in
> > console_trylock_for_printk() if we don't have a console to print to.
> > Attached patch should fix the problem.
> > 
> 
> Note, your patch changes the logic a bit. It causes the
> mutex_acquire(&console_lock_dep_map) to happen on console_suspend,
> which the original code never did.
  Yes, I know. That's actually intentional and also fixes a lockdep warning
- there was a separate patch doing exactly that flying around because
otherwise when you suspend-resume & CPU hotplug, lockdep complains because
of some cpu hotplug locks. Maybe I should note that in a changelog.

								Honza
-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/