RE: [PATCH 2/3] pwm: ftm-pwm: Convert to direct regmap API usage.

From: Li.Xiubo@xxxxxxxxxxxxx
Date: Mon Apr 28 2014 - 11:14:42 EST



> > drivers/pwm/pwm-fsl-ftm.c | 83 +++++++++++++++++++++++++----------------------
> > 1 file changed, 44 insertions(+), 39 deletions(-)
>
> This could explain the advantages of converting to regmap. Looking at
> this diffstat above, it's not immediately obvious that there's an
> advantage because you end up adding 5 lines.
>
> Again I'm guessing this is in preparation to add endianess support, and
> it will be really easy to add that using regmap, so the gains will only
> become obvious later on.
>
> That's the kind of thing I'd like to see in the patch description. It
> tells me why this patch makes sense.
>

Yes, That`s why converting to use the regmap.

I`ll update this as you have mentioned.

Thanks,
BRs
Xiubo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/