Re: [PATCH 3/3] pwm: ftm-pwm: Add big-endian support

[Thierry Reding]

On Fri, Mar 21, 2014 at 12:53:10PM +0800, Xiubo Li wrote:
> Now for the following scenarios:
> 
>      SoC     |  CPU   | FTM-PWM | 'big-endian' property is needed?
> -------------|--------|---------|---------------------------------
>     Vybird   |  LE    |   LE    |     No
>      LS1     |  LE    |   BE    |     Yes
>      LS2     |  LE    |   LE    |     No
> 
> Signed-off-by: Xiubo Li <Li.Xiubo@xxxxxxxxxxxxx>
> ---
>  drivers/pwm/pwm-fsl-ftm.c | 6 ++++++
>  1 file changed, 6 insertions(+)

And this should probably describe in text what happens. The table may
look good, but you don't give a real description of what the change
does.

Oh, and doesn't this change need to update the device tree binding since
you now have an additional property?

Thierry

Attachment: pgphNm5LjApYj.pgp
Description: PGP signature