Re: [PATCH V3] Add support for flag status register on Micron chips.

[Graham Moore]

On Mon, Apr 28, 2014 at 2:06 AM, Huang Shijie <b32955@xxxxxxxxxxxxx> wrote:
> On Mon, Apr 28, 2014 at 07:06:17AM +0200, Marek Vasut wrote:
>>
>> Two things competing over the same pointer looks misdesigned to me. I will need
>> to dig into this one more time ...
> Please refer to the code for NAND chip, the nand_get_flash_type() :
>
> -----------------------------------------------------------
>         /* Do not replace user supplied command function! */
>         if (mtd->writesize > 512 && chip->cmdfunc == nand_command)
>                 chip->cmdfunc = nand_command_lp;
> -----------------------------------------------------------
>
> It uses the same logic:
>         " Do not replace user supplied command function!"
>
> thanks
> Huang Shijie

I would like to set the @wait_till_ready in m25p80.c, because the
USE_FSR flag is only for Micron chips.  But the m25p80 driver doesn't
have access to the flags, they are contained in spi-nor.c.  It seems
to me that the driver_data should be accessible by the driver.  So
maybe there is room for improvement there.

Thanks,
Graham Moore
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/