Re: [PATCH 0/2] KVM: async_pf: use_mm/mm_users fixes

From: Paolo Bonzini
Date: Mon Apr 28 2014 - 07:06:22 EST


Il 21/04/2014 15:25, Oleg Nesterov ha scritto:
Hello.

Completely untested and I know nothing about kvm ;) Please review.

But use_mm() really looks misleading, and the usage of mm_users looks
"obviously wrong". I already sent this change while we were discussing
vmacache, but it was ignored. Since then kvm_async_page_present_sync()
was added into async_pf_execute() into async_pf_execute(), but it seems
to me that use_mm() is still unnecessary.

Oleg.

virt/kvm/async_pf.c | 10 ++++------
1 files changed, 4 insertions(+), 6 deletions(-)


Applying patch 2 to kvm/master (for 3.15).

Patch 1 will be for 3.16 only, I'd like a review from Marcelo or Andrea though (that's "KVM: async_pf: kill the unnecessary use_mm/unuse_mm async_pf_execute()" for easier googling).

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/