Re: [PATCH] mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req"

[Ulf Hansson]

On 28 April 2014 12:53, Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>> From: Micky Ching <micky_ching@xxxxxxxxxxxxxx>
>>
>> This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d.
>
> Why was this patch even merged without an MFD Ack?
>
>> commit <mmc: rtsx: add support for pre_req and post_req> did use
>> mutex_unlock() in tasklet, but mutex_unlock() can't used in
>> tasklet(atomic context). The driver need use mutex to avoid concurrency,
>> so we can't use tasklet here, the patch need to be removed.
>>
>> The spinlock host->lock and pcr->lock may deadlock, one way to solve the
>> deadlock is remove host->lock in sd_isr_done_transfer(), but if using
>> workqueue the we can avoid using the spinlock and also avoid the problem.
>>
>> Signed-off-by: Micky Ching <micky_ching@xxxxxxxxxxxxxx>
>> ---
>>  drivers/mfd/rtsx_pcr.c            |  132 ++++--------
>>  drivers/mmc/host/rtsx_pci_sdmmc.c |  418 ++++++-------------------------------
>>  include/linux/mfd/rtsx_common.h   |    1 -
>>  include/linux/mfd/rtsx_pci.h      |    6 -
>>  4 files changed, 109 insertions(+), 448 deletions(-)
>
> This patch should be sent to the -rcs as soon as possible:

Do you mind helping out doing it here Lee? Not sure how busy Chris is
at the moment.

Kind regards
Ulf Hansson

>
> Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
>
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead
> Linaro.org â Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/