Re: [PATCH v5 2/4] arm64: split syscall_trace() into separate functions for enter/exit

[AKASHI Takahiro]

On 04/16/2014 10:27 PM, Will Deacon wrote:
> Hi Akashi,
>
> On Sat, Mar 15, 2014 at 05:39:06AM +0000, AKASHI Takahiro wrote:
> > As done in arm, this change makes it easy to confirm we invoke syscall
> > related hooks, including syscall tracepoint, audit and seccomp which would
> > be implemented later, in correct order. That is, undoing operations in the
> > opposite order on exit that they were done on entry.
> >
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi@xxxxxxxxxx>
>
> [...]
>
> > +static void tracehook_report_syscall(struct pt_regs *regs,
> > +				     enum ptrace_syscall_dir dir)
> >   {
> > +	int scrach;
>
> s/scrach/scratch/

I will fix it.

> Although, I'd rather have a variable with a more meaningful name. How about
> regno?

OK, I will use regno in the next revision, which I will submit soon.

> With that,
>
>    Acked-by: Will Deacon <will.deacon@xxxxxxx>

Thank you so much,
-Takahiro AKASHI

> Cheers,
>
> Will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/