Re: [PATCH] staging: line6: fix possible overrun

[Dan Carpenter]

On Sun, Apr 27, 2014 at 10:00:43PM +0200, Mateusz Guzik wrote:
> > >  and a WARN_ON + -EINVAL in line6_init_audio to catch future
> > >  offenders.
> > 
> > Returning -EINVAL is a bad idea because it would break the driver
> > completely and make it unusable.
> > 
> 
> Well I would vote for returning the error anyway.

I'm trying to be polite, but you are talking about adding regressions
deliberately...

It's very rare for people to deliberately add regressions to the kernel.
I have only seen it one time before.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/