Re: [PATCH 1/4] acerhdf: Adding support for "manual mode"

[Peter Feuerer]

Borislav Petkov writes:

> On Sun, Apr 27, 2014 at 03:23:32AM +0200, Peter Feuerer wrote:
> > From: Peter Feuerer <peter@xxxxxxxx>
> >
> > Some Acer models require an additional command to turn off the fan after
> > bios mode has been enabled.  Adding new section in bios table to allow
> > support for those models, by writing an extra "manual mode" register.
>
> Why?
>
> That command is always the same AFAICT. So why not add a single flag to
> bios_settings_t called "needs_manual" or such and then do the required
> dance in acerhdf_change_fanstate() if it is set?

I wanted to be prepared for possible upcoming models with changed registers 
/ values.  But I guess it would make sense to go for your proposal for now 
and then afterwards we should discuss about implementing the idea of 
Andreas and split the bios_tbl.


> Btw, this "struct bios_settings_t" could lose that "_t" at the end as it
> is not a typedef. We don't like typedefs anyway. :-)

True, will put this on my todo list :)

--
--peter;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/