Re: [PATCH 29/47] staging/lustre/lnet: lnet: fix issues found by Klocwork Insight tool

[Greg Kroah-Hartman]

On Sun, Apr 27, 2014 at 01:06:53PM -0400, Oleg Drokin wrote:
> From: Dmitry Eremin <dmitry.eremin@xxxxxxxxx>
> 
> Null pointer 'cp' that comes from line 2544 may be dereferenced
> at line 2618.
> 
> Pointer 'ni' checked for NULL at line 1569 may be passed to
> function and may be dereferenced there by passing argument 1 to
> function 'lnet_ni_notify_locked' at line 1621.
> 
> Null pointer 'best_iface' that comes from line 802 may be
> dereferenced at line 832.
> 
> Buffer overflow of string buffer due to non null terminated string.
> 
> Pointer 'tsc' returned from call to function 'sfw_find_test_case'
> at line 571 may be NULL and will be dereferenced at line 572.
> 
> Local variable 'hash' is never used.

Each kernel patch should only do one thing, not 6 different things.
Please break this up into 6 different patches.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/