Re: [PATCH] do_mounts: fix not all available filesystems get tried during boot

From: ÐÐÐÐÐÐ ÐÐÑÑÐÐ
Date: Sun Apr 27 2014 - 07:08:55 EST


XFS, for one. Best see the mentioned bugzilla entries.

2014-04-27 14:04 GMT+03:00 Richard Weinberger <richard.weinberger@xxxxxxxxx>:
> On Sun, Apr 27, 2014 at 12:37 PM, ÐÐÐÐÐÐ ÐÐÑÑÐÐ <plamen.sisi@xxxxxxxxx> wrote:
>> While debugging a kernel panic with 3.14.1 it became clear that some
>> changes made some filesystems mount routines return error codes other
>> than 0, EACCES and EINVAL. Such return codes result in the kernel
>> panicking without trying to mount root with all of the available
>> filesystems, as can be seen in bugzilla entries 74901 and 74261.
>
> What filesystems are these?
>
>> Make mount_block_root continue trying other available filesystems by
>> default, not only when the last tried returned EACCES or EINVAL.
>>
>> Signed-off-by: Plamen Petrov <plamen.sisi@xxxxxxxxx>
>> ---
>> init/do_mounts.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/init/do_mounts.c b/init/do_mounts.c
>> index 09ded58..a4abbdf 100644
>> --- a/init/do_mounts.c
>> +++ b/init/do_mounts.c
>> @@ -403,7 +403,7 @@ retry:
>> case -EACCES:
>> flags |= MS_RDONLY;
>> goto retry;
>> - case -EINVAL:
>> + default:
>> continue;
>> }
>> /*
>> --
>> 1.9.0
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>
>
>
> --
> Thanks,
> //richard



--
Plamen Petrov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/