RE: [PATCH net-next 1/1] hyperv: Properly handle checksum offload

[KY Srinivasan]

> -----Original Message-----
> From: driverdev-devel-bounces@xxxxxxxxxxxxxxxxxxxxxx [mailto:driverdev-
> devel-bounces@xxxxxxxxxxxxxxxxxxxxxx] On Behalf Of KY Srinivasan
> Sent: Friday, April 25, 2014 7:24 PM
> To: Eric Dumazet; Stephen Hemminger
> Cc: olaf@xxxxxxxxx; netdev@xxxxxxxxxxxxxxx; jasowang@xxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; stable@xxxxxxxxxx; apw@xxxxxxxxxxxxx;
> devel@xxxxxxxxxxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx
> Subject: RE: [PATCH net-next 1/1] hyperv: Properly handle checksum offload
> 
> 
> 
> > -----Original Message-----
> > From: Eric Dumazet [mailto:eric.dumazet@xxxxxxxxx]
> > Sent: Friday, April 25, 2014 6:15 PM
> > To: Stephen Hemminger
> > Cc: KY Srinivasan; davem@xxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> > kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx;
> > apw@xxxxxxxxxxxxx; jasowang@xxxxxxxxxx; stable@xxxxxxxxxx
> > Subject: Re: [PATCH net-next 1/1] hyperv: Properly handle checksum
> > offload
> >
> > On Fri, 2014-04-25 at 17:43 -0700, Stephen Hemminger wrote:
> > > On Fri, 25 Apr 2014 11:45:14 -0700
> > > "K. Y. Srinivasan" <kys@xxxxxxxxxxxxx> wrote:
> > >
> > > > @@ -474,6 +477,9 @@ static int netvsc_start_xmit(struct sk_buff
> > > > *skb,
> > struct net_device *net)
> > > >  	csum_info = (struct ndis_tcp_ip_checksum_info *)((void *)ppi +
> > > >  			ppi->ppi_offset);
> > > >
> > > > +	ip_hdr(skb)->check = 0;
> > > > +	csum_info->transmit.ip_header_checksum = 1;
> > > > +
> > > >  	if (net_trans_info & (INFO_IPV4 << 16))
> > > >  		csum_info->transmit.is_ipv4 = 1;
> > > >  	else
> > >
> > > Linux doesn't need or want IP checksum offload.
> > > It will not have any performance gain.
> >
> >
> > BTW, was this patch even tested with IPv6 packets ???
> 
> No; I only tested this on ipv4.
Oops; this would not work on ipv6. I am going to resend this patch.

K. Y
> 
> K. Y
> >
> 
> _______________________________________________
> devel mailing list
> devel@xxxxxxxxxxxxxxxxxxxxxx
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/