RE: [PATCH 1/2] staging: comedi: addi_apci_1564: board does not have analog inputs

From: Hartley Sweeten
Date: Fri Apr 25 2014 - 12:07:52 EST


On Friday, April 25, 2014 1:17 AM, Chase Southwood wrote:
> This board does not have analog inputs. Remove the subdevice init for
> them.
>
> Signed-off-by: Chase Southwood <chase.southwood@xxxxxxxxx>
> Cc: Ian Abbott <abbotti@xxxxxxxxx>
> Cc: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>

Looks good.

Reviewed-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>

As Ian mentioned, after you have removed the init for all the non-existent
subdevices you should just get rid of them and only allocate the used ones.

Thanks,
Hartley

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/