Re: mmotm 2014-04-24-13-07 uploaded

[Rik van Riel]

On 04/24/2014 10:49 PM, Paul E. McKenney wrote:
> On Thu, Apr 24, 2014 at 03:40:29PM -0700, Randy Dunlap wrote:
>> On 04/24/14 13:08, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
>>> The mm-of-the-moment snapshot 2014-04-24-13-07 has been uploaded to
>>>
>>>    http://www.ozlabs.org/~akpm/mmotm/
>>>
>>> mmotm-readme.txt says
>>>
>>> README for mm-of-the-moment:
>>>
>>> http://www.ozlabs.org/~akpm/mmotm/
>>>
>>> This is a snapshot of my -mm patch queue.  Uploaded at random hopefully
>>> more than once a week.
>>>
>>> You will need quilt to apply these patches to the latest Linus release (3.x
>>> or 3.x-rcY).  The series file is in broken-out.tar.gz and is duplicated in
>>> http://ozlabs.org/~akpm/mmotm/series
>>>
>>
>> uml on x86_64 defconfig:
>>
>> drivers/built-in.o: In function `__handle_sysrq':
>> drivers/tty/sysrq.c:514: undefined reference to `rcu_sysrq_start'
>> drivers/tty/sysrq.c:558: undefined reference to `rcu_sysrq_end'
> 
> Hmmm...  Looks like Rik's patch needs declarations in rcupdate.h.
> Not sure how I missed that...  :-/

Looks like maybe sysrq.c should explicitly #include rcupdate.h.

On x86-64 the code compiled just fine, because something else
included rcupdate.h. Apparently on UML this breaks...

-- 
All rights reversed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/