Re: [PATCH 5/5] usb/xhci: fix compilation warning when !CONFIG_PCI && !CONFIG_PM

[David Cohen]

Hi Greg,

On Thu, Apr 24, 2014 at 12:50:32PM -0700, Greg KH wrote:
> On Tue, Apr 22, 2014 at 03:23:02PM +0300, Mathias Nyman wrote:
> > From: David Cohen <david.a.cohen@xxxxxxxxxxxxxxx>
> > 
> > When CONFIG_PCI and CONFIG_PM are not selected, xhci.c gets this
> > warning:
> > drivers/usb/host/xhci.c:409:13: warning: âxhci_msix_sync_irqsâ defined
> > but not used [-Wunused-function]
> > 
> > Instead of creating nested #ifdefs, this patch fixes it by defining the
> > xHCI PCI stubs as inline.
> > 
> > Signed-off-by: David Cohen <david.a.cohen@xxxxxxxxxxxxxxx>
> > Signed-off-by: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>
> > ---
> >  drivers/usb/host/xhci.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> What patch caused this problem?  Does it show up in 3.14?  3.10?  2.0?
> :)
> 
> Please be more specific...

I first noticed this warning on 3.13, but I believe it is older :)
You may consider this patch as an extension of this other one:

commit d5c82feb5cf8026cd4af048330fdcd46e861c686
Author: Olof Johansson <olof@xxxxxxxxx>
Date:   Tue Jul 23 11:58:20 2013 -0700

    usb: xhci: Mark two functions __maybe_unused
--

IMO it makes sense to apply whenever the other patch exists.

Br, David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/