Re: [PATCH 16/28] nios2: System calls handling

[Ley Foon Tan]

On Tue, Apr 22, 2014 at 8:30 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Friday 18 April 2014, Ley Foon Tan wrote:
>
>> +
>> + #define sys_mmap2 sys_mmap_pgoff
>> +
>
> You use sys_mmap_pgoff here, but
>
>> +asmlinkage long sys_mmap(unsigned long addr, unsigned long len,
>> +                     unsigned long prot, unsigned long flags,
>> +                     unsigned long fd, unsigned long offset)
>> +{
>> +     if (offset & ~PAGE_MASK)
>> +             return -EINVAL;
>> +
>> +     return sys_mmap_pgoff(addr, len, prot, flags, fd, offset >> PAGE_SHIFT);
>> +}
>
> define a separate sys_mmap() here. Doing the former should be enough.
> so you can just drop the sys_mmap definition.
Okay, will drop the sys_mmap.

Thanks.
Regards
Ley Foon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/