Re: [PATCH 17/28] nios2: Signal handling support

From: Richard Weinberger
Date: Thu Apr 24 2014 - 06:17:42 EST


Am 24.04.2014 12:13, schrieb Ley Foon Tan:
> On Thu, Apr 24, 2014 at 6:01 PM, Ley Foon Tan <lftan@xxxxxxxxxx> wrote:
>> On Sun, Apr 20, 2014 at 3:29 AM, Richard Weinberger
>> <richard.weinberger@xxxxxxxxx> wrote:
>>
>>>> +
>>>> + /* Default to using normal stack. */
>>>> + usp = regs->sp;
>>>> +
>>>> + /* This is the X/Open sanctioned signal stack switching. */
>>>> + if ((ka->sa.sa_flags & SA_ONSTACK) && (current->sas_ss_sp != 0)) {
>>>> + if (!on_sig_stack(usp))
>>>> + usp = current->sas_ss_sp + current->sas_ss_size;
>>>> + }
>>>
>>> You can use sigsp() here.
>> Okay.
>>
> I just noticed that sigsp() have struct ksignal argument. We can use
> sigsp() for nios2 because it doesn't have struct ksignal.
>
> unsigned long sigsp(unsigned long sp, struct ksignal *ksig);

Did you at look at the struct ksignal definition and the clean series I've
pointed you to?

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/