Re: [PATCH 17/28] nios2: Signal handling support

[Richard Weinberger]

Am 24.04.2014 12:01, schrieb Ley Foon Tan:
> On Sun, Apr 20, 2014 at 3:29 AM, Richard Weinberger
 >>> +
>>> +       push_cache((unsigned long) &frame->retcode);
>>> +
>>> +       /* Set up registers for signal handler */
>>> +       regs->sp = (unsigned long) frame;
>>> +       regs->r4 = (unsigned long) (current_thread_info()->exec_domain
>>> +                       && current_thread_info()->exec_domain->signal_invmap
>>> +                       && sig < 32
>>> +                       ? current_thread_info()->exec_domain->signal_invmap[sig]
>>> +                       : sig);
>>
>> Does nios2 really need signal translation and supports execution domains?
> Nios2 have one default "default_exec_domain" only. So, we can change
> this to "regs->r4 = sig;".

Nice.

> BTW, most of the architectures have similar code.

Yep, because everyone is copy&pasting from each others without thinking. 8)
There is already a cleanup going on: https://lkml.org/lkml/2014/3/2/198

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/