Re: [git pull] drm fixes

From: Christian KÃnig
Date: Thu Apr 24 2014 - 04:22:03 EST


Am 24.04.2014 00:04, schrieb Ed Tomlinson:
On Wednesday 23 April 2014 07:54:17 Dave Airlie wrote:
On Wed, Apr 23, 2014 at 1:59 AM, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
Dave, mind sending me a pull request for drm fixes?

There's now at least these two:

- "drm/radeon/aux: fix hpd assignment for aux bus"
- "drm/radeon: use fixed PPL ref divider if needed"

that look like fairly fatal regressions when they affect somebody.

The fact that we already had *two* independent bugs be reported within
days of that last out-of-merge-window pull request makes me very
unhappy with the state of drm pulls.

So please make sure that future fixes really are *fixes*. For
regressions only. No more games like this.
The pll fallout is fixes for the initial feature that was in the merge window,
Tuning plls for monitors is always a pain in the ass, the previous algorithm
took a couple of kernels a few years back to get where it was, unfortunately
HDMI came along and showed up a bunch of its shortcomings. I'm happy
Alex and Christian are on top of things in terms of tracking regressions
and making sure they get fixed,

the AUX fix yes I'm a bit pissed off about myself, but I missed a pull
from a few
weeks ago, felt guilty, and maybe should have chosen the other path and let it
wait a merge,

Christian just sent me a -fixes pull with all of these in it and I'll
send it on to you
in a few mins.
Hi

Given the fun I had with rc1 I decided to try this pull before rc2 and its working fine here.

Thanks!

Thanks for testing.

As Dave noted PLLs can be quite painful to get right, so it's unfortunately not uncommon that fixing one issue uncovers other outstanding issues like in your case.

Please leave me a note if that should ever happen again,
Christian.


Ed Tomlinson

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/