Re: [RFC PATCH 1/1] x86/apic: add apic_irqs bitmap to identify irqs from apic

From: Ingo Molnar
Date: Thu Apr 24 2014 - 03:23:10 EST



* Jason Chen <jason.cj.chen@xxxxxxxxx> wrote:

> The function irq_force_complete_move() might handle irqs based on
> the non-apic irq_chip the way apic does, which has the structure
> irq_cfg as its chip_data.
> Wrong operations on non-apic irq_chip might make its chip_data changed
> and bring unexpected issues.
> Add apic_irqs bitmap to identify irqs from apic, and filter out all other
> irq_chips by checking this bitmap.

Please update the changelog to describe the current behavior, and how
it affects your platform. (I.e. how do users notice, if at all?)

Then describe why you think that behavior should be changed. ie:
what's the reason for this patch.

Only then describe the details of the change itself.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/