Re: [PATCH v2 05/13] extcon: extcon-class: improve extcon client API

[Robert Baldyga]

On 04/22/2014 05:03 PM, Aaro Koskinen wrote:
> Hi,
> 
> On Tue, Apr 22, 2014 at 08:21:35AM +0200, Robert Baldyga wrote:
>> On 04/19/2014 12:52 PM, Aaro Koskinen wrote:
>>> On Mon, Apr 14, 2014 at 01:46:16PM +0200, Robert Baldyga wrote:
>>>>  	dev_info(&pdev->dev,
>>>> -		 "OMAP USB OTG controller rev %d.%d (%s, id=%d, vbus=%d)\n",
>>>> -		 (rev >> 4) & 0xf, rev & 0xf, config->extcon, otg_dev->id,
>>>> +		 "OMAP USB OTG controller rev %d.%d (id=%d, vbus=%d)\n",
>>>> +		 (rev >> 4) & 0xf, rev & 0xf, otg_dev->id,
>>>>  		 otg_dev->vbus);
>>>
>>> This change is unrelated to the patch and not needed.
>>>
>>
>> It's related because we no longer use config->extcon since we have
>> cable-oriented API. We can keep displaying it, but this value is
>> actually meaningless.
> 
> It's not completely meaningless, as the cable is searched using that name.
> 

Yes, I see, you're right. I have forgot that this driver doesn't use
devicetree. I will restore displaying extcon name.

Thanks!
Robert Baldyga
Samsung R&D Institute Poland

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/