Re: Why do we set _PAGE_DIRTY for page tables?

[Linus Torvalds]

On Tue, Apr 22, 2014 at 4:35 PM, H. Peter Anvin <hpa@xxxxxxxxx> wrote:
> I just noticed this:
>
> #define _PAGE_TABLE     (_PAGE_PRESENT | _PAGE_RW | _PAGE_USER |       \
>                          _PAGE_ACCESSED | _PAGE_DIRTY)
> #define _KERNPG_TABLE   (_PAGE_PRESENT | _PAGE_RW | _PAGE_ACCESSED |   \
>                          _PAGE_DIRTY)
>
> Is there a reason we set _PAGE_DIRTY for page tables?  It has no
> function, but doesn't do any harm either (the dirty bit is ignored for
> page tables)... it just looks funny to me.

I think it just got copied, and at least the A bit does matter even in
page tables (well, it gets updated, I don't know how much that
"matters"). So the fact that D is ignored is actually the odd man out.

               Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/