Re: [PATCH v5] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors

From: Zoltan Kiss
Date: Tue Apr 22 2014 - 14:03:19 EST


On 22/04/14 16:38, Ben Hutchings wrote:
On Mon, 2014-04-21 at 12:26 +0100, Luis Henriques wrote:
Hi David,

On Thu, Mar 27, 2014 at 03:29:56PM -0400, David Miller wrote:
From: Zoltan Kiss <zoltan.kiss@xxxxxxxxxx>
Date: Wed, 26 Mar 2014 22:37:45 +0000

skb_zerocopy can copy elements of the frags array between skbs, but it doesn't
orphan them. Also, it doesn't handle errors, so this patch takes care of that
as well, and modify the callers accordingly. skb_tx_error() is also added to
the callers so they will signal the failed delivery towards the creator of the
skb.

Signed-off-by: Zoltan Kiss <zoltan.kiss@xxxxxxxxxx>

Fingers crossed :-) Applied, thanks Zoltan.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html

Could you please queue this for stable as well? It has CVE-2014-2568
assigned to it and I believe it is applicable to some of the trees.

It was applied to 3.13, but needs backporting to earlier versions. I
posted my attempt in
<1397429860.10849.86.camel@xxxxxxxxxxxxxxxxxxxxxxxxxx> but it needs
testing/reviewing.

This one is a different issue, although it is very similar.

Zoli

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/