Re: [PATCH 1/3] 6lowpan: add helper to get 6lowpan namespace

From: Luis R. Rodriguez
Date: Tue Apr 22 2014 - 13:58:25 EST


On Tue, Apr 22, 2014 at 11:53:03AM +0200, Alexander Aring wrote:
> Hi,
>
> On Tue, Apr 22, 2014 at 11:44:46AM +0200, Johannes Berg wrote:
> > On Thu, 2014-04-17 at 18:22 -0700, Luis R. Rodriguez wrote:
> >
> > > +#if IS_ENABLED(CONFIG_IEEE802154_6LOWPAN)
> > > [...]
> > > +#else
> > > +static inline struct netns_ieee802154_lowpan *
> > > +net_ieee802154_lowpan(struct net *net)
> > > +{
> > > + return NULL;
> > > +}
> > > +#endif
> >
> > Why would that be needed? If nobody compiles 802.15.4 then it seems
> > nothing should reference it?
> >
> Indeed I think this is unnecessary, also.

I wanted to be sure, and I was not. Right now 6lowpan does not depend
on CONFIG_NET_NS, is this intentional? I think its fine without it
but I was not sure.

Luis

Attachment: pgpq6yMIufH4p.pgp
Description: PGP signature