Re: [PATCH v2] KVM: x86: Check for host supported fields in shadow vmcs

[Paolo Bonzini]

Il 21/04/2014 15:20, Bandan Das ha scritto:
> +	for (i = j = 0; i < max_shadow_read_write_fields; i++) {
> +

Extra empty line.  Not a big deal, but...

> +		switch (shadow_read_write_fields[i]) {
> +		case GUEST_BNDCFGS:
> +			if (!vmx_mpx_supported())
> +				continue;
> +			break;
> +		default:
> +			break;
> +		}
> +
> +		if (j < i)
> +			shadow_read_write_fields[j] =
> +				shadow_read_write_fields[i];
> +		j++;

... you need to respin anyway because the j++ is wrong.  It should be 
inside the "if".  If you prefer, you can put it in the lhs of the 
assignment, otherwise a separate statement is fine by me too.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/