Re: [PATCH next 3/4] blk-mq: user (1 << order) to implement order_to_size()

From: Jens Axboe
Date: Sat Apr 19 2014 - 01:06:13 EST


On Apr 18, 2014, at 8:17 PM, Ming Lei <tom.leiming@xxxxxxxxx> wrote:
>
>> On Sat, Apr 19, 2014 at 3:23 AM, JÃrg-Volker Peetz <jvpeetz@xxxxxx> wrote:
>>
>> Testing this with gcc 4.8.2 with order > 30 confirms that the automatic casting
>> is done operator-wise and the explicit casting is necessary.
>
> My gcc 4.8.2 doesn't complain the change, see below:

It won't complain, but that doesn't mean that it won't get it wrong. The cast is necessary.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/