Re: [PATCH v9 03/19] qspinlock: Add pending bit

From: Waiman Long
Date: Fri Apr 18 2014 - 13:07:50 EST


On 04/18/2014 04:13 AM, Peter Zijlstra wrote:
On Thu, Apr 17, 2014 at 05:20:31PM -0400, Waiman Long wrote:
+ while ((val = atomic_read(&lock->val))& _Q_LOCKED_MASK)
+ arch_mutex_cpu_relax();
That was a cpu_relax().
Yes, but arch_mutex_cpu_relax() is the same as cpu_relax() for x86.
Yeah, so why bother typing more?

Let the s390 people sort that if/when they try and make this work for
them.

OK, I can revert the change if you wish. I have no objection for that.

-Longman
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/