Re: [RFC PATCH 2/2] drivers/base: add managed token devres interfaces

From: Shuah Khan
Date: Thu Apr 17 2014 - 19:27:26 EST


On 04/17/2014 02:22 PM, Tejun Heo wrote:
On Thu, Apr 17, 2014 at 04:10:34PM -0400, Tejun Heo wrote:
Please do not implement locking
primitive directly if at all avoidable. Why can't it use a mutex
embedded in the data area of a devres entry? And if you for some
reason have to implement it directly, at least add lockdep
annotations.


Thanks. This is helpful. Yes it does simplify the code with mutex
embedded in the devres data area. I am working on a v2 patch with
that change.

-- Shuah

--
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
shuah.kh@xxxxxxxxxxx | (970) 672-0658
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/