Re: [PATCH V2 05/19] bus: omap_l3_noc: switch over to relaxed variants of readl/writel

From: Santosh Shilimkar
Date: Thu Apr 17 2014 - 17:56:50 EST


On Thursday 17 April 2014 05:52 PM, Felipe Balbi wrote:
> Hi,
>
> On Thu, Apr 17, 2014 at 03:49:21PM -0500, Nishanth Menon wrote:
>> Currently we use __raw_readl and writel in this driver, however, there
>
> __raw_* and *_relaxed variants are the same, just have a look <asm/io.h>
>
Except the relaxed version can take care of endian conversion if
needed. :-)

> 297 #define readb_relaxed(c) ({ u8 __r = __raw_readb(c); __r; })
> 298 #define readw_relaxed(c) ({ u16 __r = le16_to_cpu((__force __le16) \
> 299 __raw_readw(c)); __r; })
> 300 #define readl_relaxed(c) ({ u32 __r = le32_to_cpu((__force __le32) \
> 301 __raw_readl(c)); __r; })
> 302
> 303 #define writeb_relaxed(v,c) __raw_writeb(v,c)
> 304 #define writew_relaxed(v,c) __raw_writew((__force u16) cpu_to_le16(v),c)
> 305 #define writel_relaxed(v,c) __raw_writel((__force u32) cpu_to_le32(v),c)
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/