Re: [PATCH 3/3] perf top/tui: Update nr_entries properly after filter is applied

From: Jiri Olsa
Date: Thu Apr 17 2014 - 09:44:56 EST


On Thu, Apr 17, 2014 at 04:53:26PM +0900, Namhyung Kim wrote:

SNIP

> -static void hist_browser__update_pcnt_entries(struct hist_browser *hb)
> +static void hist_browser__update_nr_entries(struct hist_browser *hb)
> {
> u64 nr_entries = 0;
> struct rb_node *nd = rb_first(&hb->hists->entries);
> @@ -1355,7 +1358,7 @@ static void hist_browser__update_pcnt_entries(struct hist_browser *hb)
> nr_entries++;
> }
>
> - hb->nr_pcnt_entries = nr_entries;
> + hb->nr_filtered_entries = nr_entries;
> }
>
> static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
> @@ -1410,9 +1413,9 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
> if (browser == NULL)
> return -1;
>
> - if (min_pcnt) {
> + if (hists__has_filter(hists) || min_pcnt) {

seems like this could be coupled to browser__has_filter function

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/