[PATCH V2 26/36] hrtimer: take lock only once for a cpu_base in hrtimer_run_queues()

From: Viresh Kumar
Date: Fri Apr 04 2014 - 02:46:23 EST


We are taking cpu_base->lock for every clock-base in hrtimer_run_queues() and
there is nothing in there which prevents us to take this lock only once. Modify
code to take lock only once for a cpu_base.

Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
---
kernel/hrtimer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/hrtimer.c b/kernel/hrtimer.c
index 2d9a7e2..c712960 100644
--- a/kernel/hrtimer.c
+++ b/kernel/hrtimer.c
@@ -1466,8 +1466,8 @@ void hrtimer_run_queues(void)
if (cpu_base->active_bases)
hrtimer_get_softirq_time(cpu_base);

+ raw_spin_lock(&cpu_base->lock);
for_each_active_base(index, base, cpu_base, active_bases) {
- raw_spin_lock(&cpu_base->lock);
while ((node = timerqueue_getnext(&base->active))) {
struct hrtimer *timer;

@@ -1478,8 +1478,8 @@ void hrtimer_run_queues(void)

__run_hrtimer(timer, &base->softirq_time);
}
- raw_spin_unlock(&cpu_base->lock);
}
+ raw_spin_unlock(&cpu_base->lock);
}

/*
--
1.7.12.rc2.18.g61b472e

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/