Re: [PATCH V4 RESEND] Support Thinkpad X1 Carbon 2nd gen's adaptive keyboard

From: Henrique de Moraes Holschuh
Date: Mon Mar 31 2014 - 13:50:02 EST


On Tue, Mar 11, 2014, at 8:01, Shuduo Sang wrote:
> Resend patch V4. Support Thinkpad X1 Carbon 2nd generation's adaptive
> keyboard.
>
> Hi Henrique, could you please have a chance to review it?

I am unable to do a full review right now, but we can always adjust
minor details of the feature with later patches and the previous reviews
did help clean up the feature.

However: as far as I am concerned, this is an experimental feature until
it matures for a while. I'd rather we plug this somehow to the
thinkpad-acpi input map, for example.

Acked-by: Henrique de Moraes Holschuh <hmh@xxxxxxxxxx>

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/