Re: [PATCH 00/16] timers/hrtimers: Minor cleanups: Part II

From: Viresh Kumar
Date: Mon Mar 31 2014 - 10:31:26 EST


On 31 March 2014 19:08, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> And those cleanups make the compiler generate worse code at least on
> x86_64:
>
> text data bss dec hex filename
> 7475 554 0 8029 1f5d kernel/hrtimer.o
> 7706 554 0 8260 2044 kernel/hrtimer.o
>
> So just removing parameters and return values because you can get the
> same information from a datastructure is not necessarily a good thing.

Hmm.. Nice.

Okay, I will have another look at patches and do this kind of investigation
before sending it next time :) Its been fun going through these frameworks.

How do you want to proceed now? I mean, you will take the other patches
(which don't play with function parameters) as is or want me to send a single
unified patchset with all the pending patches that I have?

Thanks for your support :)

--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/