Re: [PATCH 1/4] brcm80211: deinline brcmf_chip_cr4_enterdl, save 440 bytes

From: Arend van Spriel
Date: Mon Mar 31 2014 - 03:39:45 EST


On 30/03/14 23:31, Denys Vlasenko wrote:
Automated script discovered that without forced inlining,
gcc-4.7 generates smaller code for this function.

There is no need to declare static functions inline anyway:
nowadays gcc detects single-callsite static functions
which benefit from inlining.

These patches look awfully familiar. I tend to object, but I don't know the details of this automated script. Does it only look for code size. How about execution time or is this only compile tested? The other thing is that you seem to rely on a specific gcc version. What about pre-4.7? How about different architectures. Was this determined on x86, arm, sparc, mips. All these questions make me say 'nay'.

Regards,
Arend

Signed-off-by: Denys Vlasenko <dvlasenk@xxxxxxxxxx>
---
drivers/net/wireless/brcm80211/brcmfmac/chip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/brcm80211/brcmfmac/chip.c b/drivers/net/wireless/brcm80211/brcmfmac/chip.c
index df130ef..d020b0b 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/chip.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/chip.c
@@ -933,7 +933,7 @@ static bool brcmf_chip_cm3_exitdl(struct brcmf_chip_priv *chip)
return true;
}

-static inline void
+static void
brcmf_chip_cr4_enterdl(struct brcmf_chip_priv *chip)
{
struct brcmf_core *core;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/