Re: [PATCH v3 2/4] kmemleak: allow freeing internal objects after kmemleak was disabled

[Li Zefan]

>> +	if (!kmemleak_has_leaks)
>> +		__kmemleak_do_cleanup();
>> +	else
>> +		pr_info("Disable kmemleak without freeing internal objects, "
>> +			"so you may still check information on memory leaks. "
>> +			"You may reclaim memory by writing \"clear\" to "
>> +			"/sys/kernel/debug/kmemleak\n");
> 
> Alternative text:
> 
> 		pr_info("Kmemleak disabled without freeing internal data. "
> 			"Reclaim the memory with \"echo clear > /sys/kernel/debug/kmemleak\"\n");
> 
> (I'm wouldn't bother with long lines in printk strings)
> 
> Otherwise:
> 
> Acked-by: Catalin Marinas <catalin.marinas@xxxxxxx>
> 

Thanks for the review!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/