Re: [PATCH 3/3] ARM: dts: socfpga: add gpio pieces

From: Dinh Nguyen
Date: Wed Mar 26 2014 - 11:29:48 EST




On 03/22/2014 06:28 AM, Sebastian Andrzej Siewior wrote:
On 03/21/2014 11:15 PM, delicious quinoa wrote:
snps,nr-gpios = <27>;

As noted on other thread, gpio2 is 27 wide, despite what the
documentation says. When I made that change and remove your other two
patches the gpios worked for me on a cyclone5 devkit board.

So if you fix the "#gpio-cells = <2>;" for all 3 gpios and fix
"snps,nr-gpios = <27>;" for gpio2, then this one patch looks good to
me. With these changes,

Okay will do. And I also add a note that the reference manual is wrong
here.


I've applied this patch to rocketboards/linux-socfpga-next/next-dt. I will take through the arm-soc tree for 3.16.

Dinh

Acked-by: Alan Tull <atull@xxxxxxxxxx>

Alan Tull
aka
delicous quinoa

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/