Re: [PATCH] drivers/staging/vt6655/iwctl.c fix a sparse warning

From: Greg Kroah-Hartman
Date: Wed Mar 26 2014 - 08:08:35 EST


On Wed, Mar 26, 2014 at 12:42:43AM -0700, Jimmy Li wrote:
> fix a sparse warning.
> drivers/staging/vt6655/iwctl.c:1846:35: warning: cast from restricted
> gfp_t
> drivers/staging/vt6655/iwctl.c:1846:35: warning: incorrect type in
> argument 2 (different base types)
> drivers/staging/vt6655/iwctl.c:1846:35: expected restricted gfp_t
> [usertype] flags
> drivers/staging/vt6655/iwctl.c:1846:35: got int [signed] <noident>

In the future, please don't line-wrap error/warning messages like this.

>
> Signed-off-by: Jimmy Li <coder.liss@xxxxxxxxx>
> ---
> drivers/staging/vt6655/iwctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/iwctl.c b/drivers/staging/vt6655/iwctl.c
> index ac3fc16..5e25535 100644
> --- a/drivers/staging/vt6655/iwctl.c
> +++ b/drivers/staging/vt6655/iwctl.c
> @@ -1843,7 +1843,7 @@ int iwctl_siwencodeext(struct net_device *dev,
> PRINT_K("SIOCSIWENCODEEXT...... \n");
>
> blen = sizeof(*param);
> - buf = kmalloc((int)blen, (int)GFP_KERNEL);
> + buf = kmalloc((int)blen, GFP_KERNEL);
> if (buf == NULL)
> return -ENOMEM;
> memset(buf, 0, blen);
> --
> 1.7.10.4

Thanks, I'll queue this up after 3.15-rc1 is out, as my tree is
currently closed.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/