Re: [PATCH] staging: line6: Fix missing blanks after declarations

From: Joe Perches
Date: Mon Mar 24 2014 - 17:35:31 EST


On Mon, 2014-03-24 at 21:51 +0100, Fabian Mewes wrote:
> This patch is part of eudyptula challenge task 10
>
> Signed-off-by: Fabian Mewes <architekt@xxxxxxxxxxxxxxxxx>

Hi Fabian.

The patch seems fine, but please do not use something
like the above as a commit message.

It would be better to describe _why_ the change should
be done. Something like:

------

Subject: [PATCH] staging: line6: Add blank lines after declarations

Use the more common kernel coding style.

Signed-off-by: your name <your.email@xxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/