[patch 04/16] scsi: qla1280: Add missing destroy_timer_on_stack()

From: Thomas Gleixner
Date: Sun Mar 23 2014 - 11:12:36 EST


Otherwise we leak a tracking object when DEBUG_OBJECTS is enabled.

This code should use wait_for_completion_timeout() instead, but that's
a different issue.

Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: Michael Reed <mdr@xxxxxxx>
Cc: scsi <linux-scsi@xxxxxxxxxxxxxxx>
---
drivers/scsi/qla1280.c | 1 +
1 file changed, 1 insertion(+)

Index: tip/drivers/scsi/qla1280.c
===================================================================
--- tip.orig/drivers/scsi/qla1280.c
+++ tip/drivers/scsi/qla1280.c
@@ -2514,6 +2514,7 @@ qla1280_mailbox_command(struct scsi_qla_

wait_for_completion(&wait);
del_timer_sync(&timer);
+ destroy_timer_on_stack(&timer);

spin_lock_irq(ha->host->host_lock);



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/