RE: [PATCH net-next,v3] hyperv: Add support for virtual Receive Side Scaling (vRSS)

[Haiyang Zhang]

> -----Original Message-----
> > +
> > +
> > +/* ndis_recv_scale_cap/cap_flag */
> 
> One empty line is sufficient, we don't need two of them here.

I will fix this and other formats you pointed out below, also check the whole patch 
for similar issues.

> > -	net = alloc_etherdev(sizeof(struct net_device_context));
> > +	net = alloc_etherdev_mq(sizeof(struct net_device_context),
> > +				num_online_cpus());
> >  	if (!net)
> >  		return -ENOMEM;
> >
> 
> num_online_cpus() can change, will your driver accomodate this?

HyperV currently doesn't support hot-add/remove cpu, so this is constant for 
this driver.

Thanks,
- Haiyang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/