Re: [PATCH 06/13] perf tools: Use tid in mmap/mmap2 events to find maps

From: Jiri Olsa
Date: Wed Mar 19 2014 - 06:24:46 EST


On Wed, Mar 19, 2014 at 09:13:38AM +0200, Adrian Hunter wrote:
> On 18.03.2014 23:25, Arnaldo Carvalho de Melo wrote:
> > From: Don Zickus <dzickus@xxxxxxxxxx>
> >
> > Now that we can properly synthesize threads system-wide, make sure the
> > mmap and mmap2 events use tids instead of pids to locate their maps.
>
> This is a good change but it cannot go yet because it is dependent on Jiri's
> "perf tools: Share map groups within process" series.
>
> perf tools assume that threads share virtual memory. That means that a
> mapping created by one thread is visible to all threads in the thread group.
> That was implemented by putting all the maps on the thread group leader
> (pid == tid). The alternative is to share the map groups instead, which is
> what Jiri is doing.

right, this needs the sharing map groups changes
(or the 1/2 patch Don sent prior to this patch)

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/