Re: [PATCH 2/2] INTEL-IGB: Convert iounmap to pci_iounmap

From: Jeff Kirsher
Date: Wed Mar 19 2014 - 00:33:40 EST


On Tue, 2014-03-18 at 17:11 +0100, Peter Senna Tschudin wrote:
> Use pci_iounmap instead of iounmap when the virtual mapping was done
> with pci_iomap. A simplified version of the semantic patch that finds
> this
> issue is as follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> expression addr;
> @@
> addr = pci_iomap(...)
>
> @rr@
> expression r.addr;
> @@
> * iounmap(addr)
> // </smpl>
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@xxxxxxxxx>
> ---
> Tested by compilation only.
>
> drivers/net/ethernet/intel/igb/igb_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Thanks Peter, I have added you patch to my queue.

Attachment: signature.asc
Description: This is a digitally signed message part